ci(hypatia): drop the dead #869 compile-break hold list - #1074
Merged
Merged
Conversation
The case-list held four hypatia#869-broken SHAs on 9f2f62f. Hypatia main has moved past all four (d369a80 compiles), so the branch can no longer match and is dead code. HEAD is used directly, as before the break. Recurrence is prevented upstream, not here: hypatia's Escript packaging soundness gate (proposed as a required check) stops a non-compiling main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFphKkDVB9pUDSCD4bkz65
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
enabled auto-merge (squash)
September 30, 2026 10:20
hyperpolymath
disabled auto-merge
September 30, 2026 10:30
hyperpolymath
enabled auto-merge (squash)
September 30, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the hand-maintained hypatia#869 hold list from
hypatia-scan-reusable.ymlandgovernance-reusable.yml.Hypatia main has moved past all four listed SHAs.
d369a80compiles, and hypatia#875 also clears--warnings-as-errors. So thecasecan no longer match, and each resolver goes back to using hypatia HEAD directly. The diff is a pure deletion of 22 lines; thesha=output lines are unchanged.Recurrence belongs upstream: hypatia's
Escript packaging soundnessgate, which is proposed to become a required check, stops a non-compiling main. A SHA list in every consumer isn't the right place for it.Relates to #1050, #1014 and hyperpolymath/hypatia#869.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QFphKkDVB9pUDSCD4bkz65